Check license headers in .cs-files from build-script, fail if missing.

[danielcweber]

No description provided.

[danielcweber]

@akarnokd The output of the script matches what you found missing in your unit test, right? We could merge your fixed .cs-files in.

2018-06-15T12:28:06.9105985Z D:\a\1\s\Rx.NET\Source\facades\GlobalAssemblyVersion.cs does not have a valid license header.
2018-06-15T12:28:06.9106885Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Core\TypeForwarders.Core.cs does not have a valid license header.
2018-06-15T12:28:06.9109946Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Experimental\TypeForwarders.Experimental.cs does not have a valid license header.
2018-06-15T12:28:06.9123021Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Interfaces\TypeForwarders.Interfaces.cs does not have a valid license header.
2018-06-15T12:28:06.9143254Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Linq\TypeForwarders.Linq.cs does not have a valid license header.
2018-06-15T12:28:06.9164964Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.PlatformServices\TypeForwarders.PlatformServices.cs does not have a valid license header.
2018-06-15T12:28:06.9184848Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Providers\TypeForwarders.Providers.cs does not have a valid license header.
2018-06-15T12:28:06.9250562Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Runtime.Remoting\TypeForwarders.Remoting.cs does not have a valid license header.
2018-06-15T12:28:06.9277202Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Windows.Forms\TypeForwarders.Forms.cs does not have a valid license header.
2018-06-15T12:28:06.9298454Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.Windows.Threading\TypeForwarders.Threading.cs does not have a valid license header.
2018-06-15T12:28:06.9318727Z D:\a\1\s\Rx.NET\Source\facades\System.Reactive.WindowsRuntime\TypeForwarders.WindowsRuntime.cs does not have a valid license header.
2018-06-15T12:28:07.1642451Z D:\a\1\s\Rx.NET\Source\src\System.Reactive\Linq\QueryDebugger.cs does not have a valid license header.
2018-06-15T12:28:07.4033547Z D:\a\1\s\Rx.NET\Source\tests\Tests.System.Reactive\Tests\ImmutableListTest.cs does not have a valid license header.
2018-06-15T12:28:07.4464213Z D:\a\1\s\Rx.NET\Source\tests\Tests.System.Reactive\Tests\Internal\PriorityQueueTest.cs does not have a valid license header.
2018-06-15T12:28:07.9103090Z D:\a\1\s\Rx.NET\Source\tests\Tests.System.Reactive.Uwp.DeviceRunner\App.xaml.cs does not have a valid license header.

[akarnokd]

Checking this on VSTS is one thing. I don't run the build.ps1 file locally, nor do I know how to do it, but I run all unit tests in projects when I change code. Catching and repairing missing headers is more useful then, plus I don't have to dig through those VSTS logs on the website for this particular error.

[danielcweber]

We can go for both, to make the build fail early. I merged your PR. Let's see what the rebase of this says.

[danielcweber]

@onovotny Do we still want that? There's a unit test for that, however, it takes a whole build to fail.

[clairernovotny]

I'm mostly indifferent about licenses on each file. No strong opinions either way.

[danielcweber]

Checking this during unit testing seems perfectly sufficient. Closing.