Fix formatting and apply changes from msbuild /t:pack /v:m

src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md

@@ -1788,9 +1788,9 @@ Do not guard 'Add(item)' or 'Remove(item)' with 'Contains(item)' for the set. Th
 |CodeFix|True|
 ---
 
-## [CA1869](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869): Avoid single-use of local 'JsonSerializerOptions' as it is suboptimal
+## [CA1869](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869): Cache and reuse 'JsonSerializerOptions' instances
 
-Avoid single-use of local 'JsonSerializerOptions' as it is suboptimal, use a singleton instance instead to improve performance.
+Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. Single use 'JsonSerializerOptions' instances can substantially degrade the performance of your application.
 
 |Item|Value|
 |-|-|

src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif

@@ -3294,8 +3294,8 @@
         },
         "CA1869": {
           "id": "CA1869",
-          "shortDescription": "Avoid single-use of local 'JsonSerializerOptions' as it is suboptimal",
-          "fullDescription": "Avoid single-use of local 'JsonSerializerOptions' as it is suboptimal, use a singleton instance instead to improve performance.",
+          "shortDescription": "Cache and reuse 'JsonSerializerOptions' instances",
+          "fullDescription": "Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. Single use 'JsonSerializerOptions' instances can substantially degrade the performance of your application.",
           "defaultLevel": "note",
           "helpUri": "https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869",
           "properties": {

src/NetAnalyzers/RulesMissingDocumentation.md

@@ -13,6 +13,6 @@ CA1863 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-
 CA1865 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865> | Use char overload |
 CA1866 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866> | Use char overload |
 CA1867 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1867> | Use char overload |
-CA1869 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869> | Avoid single-use of local 'JsonSerializerOptions' as it is suboptimal |
+CA1869 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869> | Cache and reuse 'JsonSerializerOptions' instances |
 CA2021 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2021> | Do not call Enumerable.Cast\<T> or Enumerable.OfType\<T> with incompatible types |
 CA2261 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2261> | Do not use ConfigureAwaitOptions.SuppressThrowing with Task\<TResult> |

src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Performance/AvoidSingleUseOfLocalJsonSerializerOptionsTests.cs

@@ -111,7 +111,7 @@ static string Serialize<T>(T value)
         [InlineData("(({|CA1869:new JsonSerializerOptions()|}))")]
         [InlineData("1 == 1 ? {|CA1869:new JsonSerializerOptions()|} : null")]
         [InlineData("1 == 1 ? null : 2 == 2 ? null : {|CA1869:new JsonSerializerOptions()|}")]
-        public Task CS_UseNewLocalOptionsAsArgument_Variants(string expression) 
+        public Task CS_UseNewLocalOptionsAsArgument_Variants(string expression)
             => VerifyCS.VerifyAnalyzerAsync($$"""
                 using System.Text.Json;