Skip to content

Commit

Permalink
Merge pull request #7016 from AbhineshJha/typo
Browse files Browse the repository at this point in the history
docs(grammatical): correct typos
  • Loading branch information
mavasani committed Nov 1, 2023
2 parents 36797a8 + 4869534 commit 91fda6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/NetCore_GettingStarted.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
- Run the analyzer locally against `dotnet/runtime` and `dotnet/roslyn-analyzers` [(instructions)](#testing-against-the-runtime-and-roslyn-analyzers-repo).
- Review each of the failures in those repositories and determine the course of action for each.
- Use the failures to discover nuance and guide the implementation details.
- Run the analyzer against `dotnet/roslyn` [(instructions)](#testing-against-the-roslyn-repo), and if feasable with `dotnet/aspnetcore` repos.
- Run the analyzer against `dotnet/roslyn` [(instructions)](#testing-against-the-roslyn-repo), and if feasible with `dotnet/aspnetcore` repos.
- Document for review: matching and non-matching scenarios, including any discovered nuance.
- All warnings and errors in these repos are addressed (to prevent build failures)
- `Info` level diagnostics do not need to be fully resolved or suppressed as they do not cause build failures
Expand Down
2 changes: 1 addition & 1 deletion docs/Performance.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ These tests are expected to live in the dotnet/roslyn-analyzers repo to make loc

#### End-to-End Tests

An end-to-end compilation test that measures how long the build takes on a large real-world project (based off existing scenarios [here](https://github.com/dotnet/performance/blob/main/docs/sdk-scenarios.md#sdk-build-throughput-scenario)). This test will be run twice, once with all muti-core build features disabled (no `/m` is passed to msbuild, and `/parallel-` is passed to the compiler) and once with the SDK defaults enabled. The reason we will want a test with no parallelism is to make it easier to see the source of regressions. These test will not just measure how long it takes analyzers to execute but the entire SDK-based build process. It will need to collect an ETL file for investigation as well as the following metrics in a binlog file
An end-to-end compilation test that measures how long the build takes on a large real-world project (based off existing scenarios [here](https://github.com/dotnet/performance/blob/main/docs/sdk-scenarios.md#sdk-build-throughput-scenario)). This test will be run twice, once with all mutli-core build features disabled (no `/m` is passed to msbuild, and `/parallel-` is passed to the compiler) and once with the SDK defaults enabled. The reason we will want a test with no parallelism is to make it easier to see the source of regressions. These test will not just measure how long it takes analyzers to execute but the entire SDK-based build process. It will need to collect an ETL file for investigation as well as the following metrics in a binlog file

- How much time was spend in analysis (`/p:reportanalyzer=true`)
- How long each build task took (recorded by default in the binlog file)
Expand Down

0 comments on commit 91fda6d

Please sign in to comment.