Skip to content

Commit

Permalink
Update message to use just one arg for the method
Browse files Browse the repository at this point in the history
  • Loading branch information
@mrahhal
mrahhal committed Jul 26, 2023
1 parent cfec118 commit f159d4c
Show file tree
Hide file tree
Showing 15 changed files with 28 additions and 30 deletions.
2 changes: 1 addition & 1 deletion src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
View file
Expand Up @@ -2109,7 +2109,7 @@ Widening and user defined conversions are not supported with generic types.</val
<value>The char overload is a better performing overload than a string with a single char.</value>
</data>
<data name="UseStringMethodCharOverloadWithSingleCharactersMessage" xml:space="preserve">
<value>Use '{0}' instead of '{1}' when you have a string with a single char</value>
<value>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</value>
</data>
<data name="UseStringMethodCharOverloadWithSingleCharactersTitle" xml:space="preserve">
<value>Use char overload</value>
Expand Down
4 changes: 1 addition & 3 deletions ...icrosoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
View file
Expand Up @@ -142,9 +142,7 @@ private void CheckIfRuleIsApplicableAndRegister(CompilationStartAnalysisContext
var argumentList = GetArgumentList(stringArgument.Syntax);
if (argumentList != null)
{
var arg0 = $"string.{method}(char)";
var arg1 = $"string.{method}(string)";
context.ReportDiagnostic(argumentList.CreateDiagnostic(rule, new[] { arg0, arg1 }));
context.ReportDiagnostic(argumentList.CreateDiagnostic(rule, new[] { method }));
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Obecné přetypování (IL unbox.any) používané sekvencí vrácenou metodou E
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Erweiterungen und benutzerdefinierte Konvertierungen werden bei generischen Type
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ La ampliación y las conversiones definidas por el usuario no se admiten con tip
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Les conversions étendues et définies par l’utilisateur ne sont pas prises en
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ L'ampliamento e le conversioni definite dall'utente non sono supportate con tipi
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Enumerable.OfType&lt;T&gt; で使用されるジェネリック型チェック (
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Enumerable.OfType&lt;T&gt;에서 사용하는 제네릭 형식 검사(C# 'is'
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Konwersje poszerzane i zdefiniowane przez użytkownika nie są obsługiwane w pr
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...alyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Ampliação e conversões definidas pelo usuário não são compatíveis com tip
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Widening and user defined conversions are not supported with generic types.</sou
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Genel türlerde genişletme ve kullanıcı tanımlı dönüştürmeler desteklen
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Enumerable.OfType&lt;T&gt; 使用的泛型类型检查 (C# 'is' operator/IL 'isi
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down
4 changes: 2 additions & 2 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf
View file
Expand Up @@ -3174,8 +3174,8 @@ Enumerable.OfType&lt;T&gt; 使用的一般型別檢查 (C# 'is' operator/IL 'isi
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersMessage">
<source>Use '{0}' instead of '{1}' when you have a string with a single char</source>
<target state="new">Use '{0}' instead of '{1}' when you have a string with a single char</target>
<source>Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</source>
<target state="new">Use 'string.{0}(char)' instead of 'string.{0}(string)' when you have a string with a single char</target>
<note />
</trans-unit>
<trans-unit id="UseStringMethodCharOverloadWithSingleCharactersTitle">
Expand Down

0 comments on commit f159d4c

Please sign in to comment.