New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1508 should not warn on as expression #4411

Closed

JohanLarsson opened this issue Nov 5, 2020 · 0 comments · Fixed by #4358

Labels

JohanLarsson commented Nov 5, 2020

class A
{
    void M(object o)
    {
        if (o is A a)
        {
        //  ↓↓↓↓↓ CA1508
            (a as B)?.ToString();
        }
    }
}

class B : A
{
}

sharwell added Area-Microsoft.CodeQuality.Analyzers False_Positive labels

mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue


          Fix another CA1508 issue (dotnet#4411)

0f4e579

mavasani mentioned this issue

Fix CA1508 bugs #4358

Merged

mavasani added the 4 - In Review label

mavasani closed this as completed in #4358

jmarolf mentioned this issue

infrastructure/report test hangs and crashes jmarolf/roslyn-analyzers#1

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment