Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source-build pre-built detection #6606

Closed
oleksandr-didyk opened this issue Apr 24, 2023 · 4 comments · Fixed by #6610
Closed

Enable source-build pre-built detection #6606

oleksandr-didyk opened this issue Apr 24, 2023 · 4 comments · Fixed by #6610

Comments

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented Apr 24, 2023

Part of dotnet/source-build#3017

As part of source-builds team's ongoing work for making .NET source-build sustainable, we are trying to eliminate pre-builts at repo level - dependencies that are not build by source-build or the repo itself (broader definition with examples and description can be found here). This would be facilitated by existing Arcade build logic that would detect pre-builts as part of the repo's build.

However, before we can enable the logic we first need to resolve existing pre-builts. Full list can be found below:

Full list of pre-builts
    <Usage Id="Microsoft.CodeAnalysis" Version="3.8.0" IsDirectDependency="true" />
      <Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0" />
	  <Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.8.0" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.0.0" />
	    <Usage Id="System.Runtime.CompilerServices.Unsafe" Version="4.7.1" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.8.0" />
      <Usage Id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="3.8.0" />
	  <Usage Id="Microsoft.CodeAnalysis.VisualBasic" Version="3.8.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.8.0" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.0.0" />
	    <Usage Id="System.Runtime.CompilerServices.Unsafe" Version="4.7.1" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.8.0" />
	    <Usage Id="Microsoft.Bcl.AsyncInterfaces" Version="1.1.1" />
	    <Usage Id="System.Composition" Version="1.0.31" />

    <Usage Id="Microsoft.CodeAnalysis" Version="3.7.0" IsDirectDependency="true" />
      <Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.7.0" />
	  <Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.7.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.7.0" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.0.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.7.0" />
      <Usage Id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="3.7.0" />
	  <Usage Id="Microsoft.CodeAnalysis.VisualBasic" Version="3.7.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.7.0" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.0.0" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.7.0" />
	    <Usage Id="System.Composition" Version="1.0.31" />

    <Usage Id="Microsoft.CodeAnalysis" Version="3.3.1" IsDirectDependency="true" />
      <Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.3.1" />
	  <Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" />
	    <Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.3.1" />
      <Usage Id="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="3.3.1" />
	  <Usage Id="Microsoft.CodeAnalysis.VisualBasic" Version="3.3.1" />
	  <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" />
	    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" />
	    <Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" />
	  <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.3.1" />
	    <Usage Id="System.Composition" Version="1.0.31" />

    <Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.9.0" IsDirectDependency="true" />
    <Usage Id="Microsoft.CodeAnalysis.VisualBasic" Version="3.9.0" IsDirectDependency="true" />
    <Usage Id="Microsoft.CodeAnalysis.Common" Version="3.9.0" />

    <Usage Id="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" IsDirectDependency="true" />

    <Usage Id="Microsoft.Net.Compilers.Toolset" Version="4.5.0" IsDirectDependency="true" IsAutoReferenced="true" />

Specific direct dependencies that are marked as pre-builts:

CC: @MichaelSimons

@MichaelSimons
Copy link
Member

cc @mmitche

@sharwell
Copy link
Member

sharwell commented May 2, 2023

@oleksandr-didyk It's not clear if/how this is a bug with this repository. It also sounds like this issue is an aggregate issue covering several smaller issues. Can we break them down one at a time to determine if/how each would need to be addressed?

@oleksandr-didyk
Copy link
Contributor Author

@oleksandr-didyk Oleksandr Didyk FTE It's not clear if/how this is a bug with this repository. It also sounds like this issue is an aggregate issue covering several smaller issues. Can we break them down one at a time to determine if/how each would need to be addressed?

Sure thing, I can create separate issues for each + have this one as tracking

@oleksandr-didyk
Copy link
Contributor Author

@oleksandr-didyk Oleksandr Didyk FTE It's not clear if/how this is a bug with this repository. It also sounds like this issue is an aggregate issue covering several smaller issues. Can we break them down one at a time to determine if/how each would need to be addressed?

Sure thing, I can create separate issues for each + have this one as tracking

Created the issues, removed comments with duplicating information + added more context to the issue's description. I apologize for it not being clear in the beginning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants