Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA3147 handle non-async Task<ActionResult-derived> ASP.NET MVC controller action methods #2737

Merged
merged 1 commit into from Aug 2, 2019
Merged

CA3147 handle non-async Task<ActionResult-derived> ASP.NET MVC controller action methods #2737

merged 1 commit into from Aug 2, 2019

Conversation

dotpaul
Copy link
Contributor

@dotpaul dotpaul commented Aug 1, 2019 •
edited

Fixes #2721 more.

nathanstocking
nathanstocking approved these changes Aug 2, 2019
View reviewed changes
Copy link

@nathanstocking nathanstocking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine and well-tested.

@dotpaul
Copy link
Contributor Author

dotpaul commented Aug 2, 2019

Thanks @nathanstocking !

@dotpaul dotpaul merged commit 9d67fbc into dotnet:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanstocking nathanstocking nathanstocking approved these changes

@LLLXXXCCC LLLXXXCCC Awaiting requested review from LLLXXXCCC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA3147 does not account for async
2 participants
@dotpaul @nathanstocking