Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA2012 change severity from Hidden to Info #3948

Merged
merged 2 commits into from Aug 4, 2020

Conversation

carlossanlop
Copy link
Member

As requested by @stephentoub, this rule was initially merged with severity Hidden and we want it to be Info instead.

@carlossanlop carlossanlop requested a review from a team as a code owner August 4, 2020 17:53
@carlossanlop carlossanlop self-assigned this Aug 4, 2020
@carlossanlop
Copy link
Member Author

I am not entirely sure these changes are the correct ones, I think I am missing some other change(s). Can you please help me, @mavasani @Evangelink ? I am getting this build error:

Build FAILED.

Microsoft.NetCore.Analyzers\Tasks\UseValueTasksCorrectly.cs(27,103): error RS2001: Rule 'CA2012' has a changed 'Category' or 'Severity' from the last release. Either revert the update(s) in source 
 or add a new up-to-date entry to unshipped release file. [D:\roslyn-analyzers\src\NetAnalyzers\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj]
Microsoft.NetCore.Analyzers\Tasks\UseValueTasksCorrectly.cs(36,106): error RS2001: Rule 'CA2012' has a changed 'Category' or 'Severity' from the last release. Either revert the update(s) in source 
 or add a new up-to-date entry to unshipped release file. [D:\roslyn-analyzers\src\NetAnalyzers\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj]
Microsoft.NetCore.Analyzers\Tasks\UseValueTasksCorrectly.cs(45,113): error RS2001: Rule 'CA2012' has a changed 'Category' or 'Severity' from the last release. Either revert the update(s) in source 
 or add a new up-to-date entry to unshipped release file. [D:\roslyn-analyzers\src\NetAnalyzers\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj]
Microsoft.NetCore.Analyzers\Tasks\UseValueTasksCorrectly.cs(54,121): error RS2001: Rule 'CA2012' has a changed 'Category' or 'Severity' from the last release. Either revert the update(s) in source 
 or add a new up-to-date entry to unshipped release file. [D:\roslyn-analyzers\src\NetAnalyzers\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj]
AnalyzerReleases.Unshipped.md(51,1): error RS2007: Analyzer release file 'AnalyzerReleases.Unshipped.md' has an invalid 'Changed' entry without a prior shipped release for the rule 'CA2012'. Inste 
ad, add a separate 'Changed' entry for the rule in unshipped release file. [D:\roslyn-analyzers\src\NetAnalyzers\Core\Microsoft.CodeAnalysis.NetAnalyzers.csproj]
    0 Warning(s)
    5 Error(s)

@mavasani
Copy link
Member

mavasani commented Aug 4, 2020

@carlossanlop Seems like the two files changed in this PR were manual edits, which should not be done. Instead, please just update the severity in UseValueTasksCorrectly.cs, which should offer a code fix to fixup AnalyzerReleases.unshipped.md. Also, you don't need to update any other files.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #3948 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3948   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files        1153     1153           
  Lines      254473   254473           
  Branches    15245    15245           
=======================================
+ Hits       243395   243399    +4     
+ Misses       9140     9136    -4     
  Partials     1938     1938           

@carlossanlop carlossanlop merged commit 98575ff into dotnet:master Aug 4, 2020
@carlossanlop carlossanlop deleted the hidden branch April 7, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants