CA1024: Do not report on tasks return types #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Aug 7, 2020
Comment on lines
+77
to
+81
| if (methodSymbol.IsGenericMethod || | ||
| methodSymbol.IsVirtual || | ||
| methodSymbol.IsOverride || | ||
| methodSymbol.Name == GetHashCodeName || | ||
| methodSymbol.Name == GetEnumeratorName || |
There was a problem hiding this comment.
I think these checks shall be done before the MatchesConfiguredVisibility.
Codecov Report
@@ Coverage Diff @@
## master #3972 +/- ##
==========================================
- Coverage 95.62% 95.62% -0.01%
==========================================
Files 1155 1155
Lines 254863 254927 +64
Branches 15266 15271 +5
==========================================
+ Hits 243724 243781 +57
- Misses 9183 9193 +10
+ Partials 1956 1953 -3 |
mavasani
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3877