Fix oblivious analysis of type parameters #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
force-pushed
the
oblivious-typeparam
branch
from
5a7d8e1
to
24b7023
Compare
Evangelink
reviewed
Oct 2, 2020
Comment on lines
560
to
568
| foreach (var typeParameter in typeParameters) | ||
| { | ||
| if (ObliviousDetector.CheckTypeParameterConstraints(typeParameter)) | ||
| { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
What about
Suggested change
| foreach (var typeParameter in typeParameters) | |
| { | |
| if (ObliviousDetector.CheckTypeParameterConstraints(typeParameter)) | |
| { | |
| return true; | |
| } | |
| } | |
| return false; | |
| return typeParameters.Any(typeParameter => ObliviousDetector.CheckTypeParameterConstraints(typeParameter)); | |
| ``` #WontFix |
| } | ||
|
|
||
| var typeParameters = ((IMethodSymbol)symbol).TypeParameters; | ||
| foreach (var typeParameter in typeParameters) |
There was a problem hiding this comment.
Same suggestion here. #WontFix
Comment on lines
+885
to
+893
| if (symbol.IsReferenceType && | ||
| symbol.NullableAnnotation() == NullableAnnotation.None) | ||
| { | ||
| // Example: | ||
| // I<TReferenceType~> | ||
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (symbol.IsReferenceType && | |
| symbol.NullableAnnotation() == NullableAnnotation.None) | |
| { | |
| // Example: | |
| // I<TReferenceType~> | |
| return true; | |
| } | |
| return false; | |
| // Example: | |
| // I<TReferenceType~> | |
| return symbol.IsReferenceType && | |
| symbol.NullableAnnotation() == NullableAnnotation.None; |
| { | ||
| // where T : class~ | ||
| return true; | ||
| } | ||
|
|
||
| foreach (var constraintType in symbol.ConstraintTypes) |
There was a problem hiding this comment.
Could also be refactored as a .Any() call. #WontFix
There was a problem hiding this comment.
I prefer the explicit loop style. One reason is it's easier to step through. #WontFix
| C<T> | ||
| "; | ||
|
|
||
| await VerifyCSharpAsync(source, shippedText, unshippedText, System.Array.Empty<DiagnosticResult>()); |
There was a problem hiding this comment.
I am curious on the why you are passing the empty array. Is it for clarity? Allocation? Something else?
Codecov Report
@@ Coverage Diff @@
## master #4246 +/- ##
========================================
Coverage 95.80% 95.81%
========================================
Files 1170 1168 -2
Lines 264491 264737 +246
Branches 15961 15969 +8
========================================
+ Hits 253390 253645 +255
+ Misses 9082 9076 -6
+ Partials 2019 2016 -3 |
Evangelink
approved these changes
Oct 3, 2020
mavasani
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4040