Ignore identity conversions in UseValueTasksCorrectly

[stephentoub]

Fixes #4271
cc: @NickCraver

[mavasani]

@stephentoub Did you mean to target this to release/dotnet5-rc2 branch? Master is now targeting .NET6

[stephentoub]

Did you mean to target this to release/dotnet5-rc2 branch? Master is now targeting .NET6

In dotnet/runtime we check in first to master and then backport to a release branch when it's approved. Does dotnet/roslyn-analyzers work differently? If this meets whatever bar is in place for dotnet5-rc2, I'd certainly like to get it in.

[mavasani]

In dotnet/runtime we check in first to master and then backport to a release branch when it's approved. Does dotnet/roslyn-analyzers work differently? If this meets whatever bar is in place for dotnet5-rc2, I'd certainly like to get it in.

Tagging @jmarolf @jeffhandley. We do not have any official approval process or bar as of now, but something we should put in place. For now, we merge critical bug fixes directly into dotnet5-rc2 and they flow into master through regular codeflow. I think it would be fine to retarget this PR to that branch.

[codecov]

Codecov Report

Merging #4274 into release/dotnet5-rc2 will decrease coverage by 0.00%.
The diff coverage is 94.44%.

@@                   Coverage Diff                   @@
##           release/dotnet5-rc2    #4274      +/-   ##
=======================================================
- Coverage                95.79%   95.78%   -0.01%     
=======================================================
  Files                     1164     1164              
  Lines                   263755   263773      +18     
  Branches                 15911    15912       +1     
=======================================================
+ Hits                    252660   252663       +3     
- Misses                    9083     9102      +19     
+ Partials                  2012     2008       -4     

[stephentoub]

Ok, thanks, retargeted.