Harden InterproceduralAnalysisConfiguration to prevent null tree argu…

[mavasani]

…ment

Change the API argument for InterproceduralAnalysisConfiguration.Create to avoid null syntax tree being passed into it.

Fixes #4491. I will create a separate PR to port the fix to 2.9.x branch

[mavasani]

This is the core change, everything else in the PR is just boiler plate changes. For VB assembly attributes, owning symbol of operation block callback is the global namespace symbol, whose first location is some embedded source with null syntax tree.

[mavasani]

I will create a separate PR to port the fix to 2.9.x branch

@dotpaul - I figured out that this issue does not repro on 2.9.x branch as the support for passing in symbol or tree into the constructor of InterproceduralAnalysisConfiguration was added during 3.3.x when editorconfig options support was added. Constructor on 2.9.x:

roslyn-analyzers/src/Utilities/FlowAnalysis/FlowAnalysis/Framework/DataFlow/InterproceduralAnalysisConfiguration.cs

Lines 40 to 47 in ed4a12c

	public static InterproceduralAnalysisConfiguration Create(
	AnalyzerOptions analyzerOptions,
	DiagnosticDescriptor rule,
	InterproceduralAnalysisKind defaultInterproceduralAnalysisKind,
	CancellationToken cancellationToken,
	uint defaultMaxInterproceduralMethodCallChain = DefaultMaxInterproceduralMethodCallChain,
	uint defaultMaxInterproceduralLambdaOrLocalFunctionCallChain = DefaultMaxInterproceduralLambdaOrLocalFunctionCallChain)
	{

[codecov]

Codecov Report

Merging #4492 (23619eb) into release/5.0.2xx (f7aad5c) will decrease coverage by 0.00%.
The diff coverage is 61.40%.

@@                 Coverage Diff                 @@
##           release/5.0.2xx    #4492      +/-   ##
===================================================
- Coverage            95.79%   95.79%   -0.01%     
===================================================
  Files                 1164     1164              
  Lines               264445   264459      +14     
  Branches             15976    15979       +3     
===================================================
+ Hits                253322   253330       +8     
- Misses                9098     9101       +3     
- Partials              2025     2028       +3     

[dotpaul]

🚢

[mavasani]

Thanks you Paul!