Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization failure #4583

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix localization failure #4583

merged 2 commits into from
Dec 16, 2020

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Dec 16, 2020

Use localization strings for diagnostic arguments instead of hard coded English

@buyaa-n buyaa-n requested a review from a team as a code owner December 16, 2020 21:44
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #4583 (946a17d) into master (6d84e09) will increase coverage by 0.00%.
The diff coverage is 96.22%.

@@           Coverage Diff            @@
##           master    #4583    +/-   ##
========================================
  Coverage   95.83%   95.84%            
========================================
  Files        1177     1179     +2     
  Lines      268158   268733   +575     
  Branches    16192    16224    +32     
========================================
+ Hits       257002   257572   +570     
- Misses       9065     9085    +20     
+ Partials     2091     2076    -15     

@buyaa-n buyaa-n merged commit 46c1e52 into dotnet:master Dec 16, 2020
@buyaa-n buyaa-n deleted the fix_loc_failure branch December 16, 2020 23:38
buyaa-n added a commit to buyaa-n/roslyn-analyzers that referenced this pull request Feb 9, 2021
genlu added a commit that referenced this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants