Illustrate unexpected oblivious on implicit containing type in public API #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4681 +/- ##
==========================================
- Coverage 95.79% 95.79% -0.01%
==========================================
Files 1193 1193
Lines 270350 270395 +45
Branches 16300 16302 +2
==========================================
+ Hits 258982 259014 +32
+ Misses 9289 9288 -1
- Partials 2079 2093 +14 |
mavasani
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a couple of tests to illustrate a compiler issue that's affecting the publicAPI analyzer (complaining about oblivious in code that is seemingly fully nullable-enabled).
Taggging @mavasani for review.