OSX is alias for MacOS #4952
Merged
OSX is alias for MacOS #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx-preview3 #4952 +/- ##
=========================================================
Coverage 95.58% 95.58%
=========================================================
Files 1177 1177
Lines 269839 269899 +60
Branches 16354 16357 +3
=========================================================
+ Hits 257916 257974 +58
Misses 9791 9791
- Partials 2132 2134 +2 |
jeffhandley
approved these changes
Mar 16, 2021
carlossanlop
approved these changes
Mar 17, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs
Show resolved
Hide resolved
...nalyzers/UnitTests/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformStringTest.cs
Show resolved
Hide resolved
Merged
This was referenced Aug 30, 2021
Merged
This was referenced Sep 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/runtime#49323
While testing the Known Platform names analyzer in runtime repo we discovered that runtime repo is using OSX in TFM which is alias (old name) of MacOS. As OSX can be used instead if MacOS we should add it as known platform in case MacOS exist in the known platforms list