Better diagnostic location for types #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgovind
commented
Aug 24, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Show resolved
Hide resolved
buyaa-n
approved these changes
Aug 25, 2021
...etAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpDetectPreviewFeatureAnalyzer.cs
Outdated
Show resolved
Hide resolved
...etAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpDetectPreviewFeatureAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Show resolved
Hide resolved
Comment on lines
+213
to
+215
| public partial {classOrStruct} Zoo"; | ||
|
|
||
| csInput += @": NonPreviewInterface, {|#0:IFoo|} |
There was a problem hiding this comment.
NIT: Here and all other tests:
Not sure why added this string concatenation, do you think it looks better?
There was a problem hiding this comment.
do you think it looks better?
Yup. String interpolation uses {} and the diagnostic markers also use {| |}. Then I needed to change the code blocks using { to {{ to construct csInput, so I decided to just split it at an appropriate place. Is this harder to read though? If it is, then I'll change it in the next PR
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx #5402 +/- ##
===================================================
- Coverage 95.56% 95.54% -0.02%
===================================================
Files 1257 1259 +2
Lines 289065 289252 +187
Branches 17368 17377 +9
===================================================
+ Hits 276244 276379 +135
- Misses 10500 10540 +40
- Partials 2321 2333 +12 |
jmarolf
approved these changes
Aug 30, 2021
Merged
This was referenced Sep 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented better diagnostic locations for types implementing preview interfaces. Instead of the diagnostic appearing on the type itself, it now appears on the interface in the interface list. I think this is a good starting point to get feedback first, and if I get sign off here, I can merge this PR and work on improving the diagnostic location for methods and other types with the same approach.