Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS2014 handling of stackalloc in a foreach expression #5700

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

stephentoub
Copy link
Member

Fixes #5693

@stephentoub stephentoub requested a review from a team as a code owner November 4, 2021 02:34
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #5700 (9392dd3) into main (f3bdbd1) will increase coverage by 0.00%.
The diff coverage is 97.43%.

@@           Coverage Diff           @@
##             main    #5700   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files        1281     1281           
  Lines      295979   296017   +38     
  Branches    18047    18050    +3     
=======================================
+ Hits       282827   282871   +44     
+ Misses      10705    10696    -9     
- Partials     2447     2450    +3     

@stephentoub stephentoub merged commit 4194a56 into dotnet:main Nov 4, 2021
@stephentoub stephentoub deleted the fixstackallocforeach branch November 4, 2021 12:20
@github-actions github-actions bot added this to the vNext milestone Nov 4, 2021
@jmarolf jmarolf modified the milestones: vNext, .NET 7.x Nov 15, 2022
@Youssef1313 Youssef1313 mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA2014 triggered erroneously for stackalloc'd collection
3 participants