Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1850 codefix to keep trivia if it's interesting #5703

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

wzchua
Copy link
Contributor

@wzchua wzchua commented Nov 4, 2021

Fixes #5683

@wzchua wzchua requested a review from a team as a code owner November 4, 2021 13:09
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #5703 (b7ce64a) into main (e2d60ad) will increase coverage by 0.00%.
The diff coverage is 97.93%.

@@           Coverage Diff            @@
##             main    #5703    +/-   ##
========================================
  Coverage   95.56%   95.56%            
========================================
  Files        1281     1281            
  Lines      296329   296544   +215     
  Branches    18084    18096    +12     
========================================
+ Hits       283180   283387   +207     
+ Misses      10708    10699     -9     
- Partials     2441     2458    +17     

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@buyaa-n
Copy link
Member

buyaa-n commented Nov 12, 2021

Closing and reopening to rerun the builds

@buyaa-n buyaa-n closed this Nov 12, 2021
@buyaa-n buyaa-n reopened this Nov 12, 2021
@buyaa-n
Copy link
Member

buyaa-n commented Nov 15, 2021

Oops got conflicts after your other PR merge @wzchua

@wzchua
Copy link
Contributor Author

wzchua commented Nov 16, 2021

Fixed @buyaa-n

@buyaa-n
Copy link
Member

buyaa-n commented Nov 16, 2021

Thanks for the prompt fix @wzchua

@buyaa-n buyaa-n merged commit 6d3dee3 into dotnet:main Nov 16, 2021
@github-actions github-actions bot added this to the vNext milestone Nov 16, 2021
@jmarolf jmarolf modified the milestones: vNext, .NET 7.x Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1850 (ComputeHash) code fix eats starting ifdef
3 participants