-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all Debug.Assert(...) overloads in flow analysis #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
commented
Dec 10, 2021
src/Utilities/FlowAnalysis/FlowAnalysis/Framework/DataFlow/DataFlowOperationVisitor.cs
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #5764 +/- ##
==========================================
+ Coverage 95.56% 95.57% +0.01%
==========================================
Files 1281 1283 +2
Lines 296017 296777 +760
Branches 18050 18096 +46
==========================================
+ Hits 282874 283658 +784
+ Misses 10709 10667 -42
- Partials 2434 2452 +18 |
mavasani
approved these changes
Dec 11, 2021
Evangelink
reviewed
Dec 11, 2021
...ft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.GuardedCallsTests.cs
Outdated
Show resolved
Hide resolved
src/Utilities/FlowAnalysis/FlowAnalysis/Framework/DataFlow/DataFlowOperationVisitor.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Dec 11, 2021
src/Utilities/FlowAnalysis/FlowAnalysis/Framework/DataFlow/DataFlowOperationVisitor.cs
Show resolved
Hide resolved
Perf failure unrelated, filed an issue, mergin the PR |
MartyIX
reviewed
Jan 14, 2022
/// Checks if the method is an overload of the <see cref="Debug.Assert(bool)"/> method. | ||
/// </summary> | ||
/// <param name="method">The IMethodSymbol to test.</param> | ||
/// <returns>True if the method is an overlaod of the <see cref="Debug.Assert(bool)"/> method.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// <returns>True if the method is an overload of the <see cref="Debug.Assert(bool)"/> method.</returns>
:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5403
Flow analysis doesn't support
Debug.Assert(bool, string? message)
or any other overload exceptDebug.Assert(bool)
:I believe all overloads of Debug.Assert(...) should be supported cc @mavasani