Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1826 (Use property instead of Linq Enumerable method): Don't remove null suppression #5796

Merged
merged 5 commits into from
Jan 28, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 17, 2022

Commit by commit review is needed.

Fixes #5795

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 17, 2022 19:57
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #5796 (954780b) into main (c314521) will increase coverage by 0.00%.
The diff coverage is 99.89%.

@@           Coverage Diff            @@
##             main    #5796    +/-   ##
========================================
  Coverage   95.57%   95.58%            
========================================
  Files        1284     1285     +1     
  Lines      296814   297046   +232     
  Branches    18101    18102     +1     
========================================
+ Hits       283694   283944   +250     
+ Misses      10676    10661    -15     
+ Partials     2444     2441     -3     

@Youssef1313
Copy link
Member Author

@mavasani Should I target .NET 6 branch?

@mavasani
Copy link
Member

Tagging @jmarolf for branch. I think we are only taking high-pri fixes for .NET6, but Jon should confirm.

@Youssef1313
Copy link
Member Author

This is definitely not high priority.

Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mavasani mavasani merged commit f1c0532 into dotnet:main Jan 28, 2022
@github-actions github-actions bot added this to the vNext milestone Jan 28, 2022
@Youssef1313 Youssef1313 deleted the ca1826-nullforgiving-fix branch January 28, 2022 07:58
@jmarolf jmarolf modified the milestones: vNext, .NET 7.x Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1826 refactoring looses ! operator
3 participants