Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception: "Passing '.editorconfig' files as additional files is no longer needed." #5803

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

Youssef1313
Copy link
Member

Closes #5725
Closes #5748

@sharwell @mavasani Do you think this is a good fix?

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 18, 2022 16:09
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #5803 (3312d4d) into main (6c43d21) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5803      +/-   ##
==========================================
- Coverage   95.58%   95.58%   -0.01%     
==========================================
  Files        1284     1284              
  Lines      296837   296834       -3     
  Branches    18102    18101       -1     
==========================================
- Hits       283728   283715      -13     
- Misses      10672    10676       +4     
- Partials     2437     2443       +6     

Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we have any other or better alternative then getting rid of this AD0001

@mavasani mavasani merged commit 1818a53 into dotnet:main Jan 18, 2022
@github-actions github-actions bot added this to the vNext milestone Jan 18, 2022
@Youssef1313 Youssef1313 deleted the patch-17 branch January 18, 2022 17:30
@Youssef1313
Copy link
Member Author

Tagging @gewarren for any needed doc updates.

@Youssef1313
Copy link
Member Author

@gewarren For more context, there is still a possible breaking change, but it's very very minor and a "silent" one.

If .editorconfig was passed as an additional file, and it's not in the project's directory (or an ancestor directory), then it won't be used. But this is very uncommon, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants