Enable generated code analysis but analyze razor/cshtml pages only #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
commented
Apr 26, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Show resolved
Hide resolved
buyaa-n
commented
Apr 26, 2022
| @@ -126,13 +125,15 @@ public sealed partial class PlatformCompatibilityAnalyzer : DiagnosticAnalyzer | |||
| isPortedFxCopRule: false, | |||
| isDataflowRule: false); | |||
|
|
|||
| protected abstract bool IsSingleLineComment(SyntaxTrivia trivia); | |||
There was a problem hiding this comment.
We might want to move the language specific code into the Utilities instead
buyaa-n
commented
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #5976 +/- ##
==========================================
- Coverage 96.03% 96.03% -0.01%
==========================================
Files 1338 1341 +3
Lines 307197 307463 +266
Branches 9788 9814 +26
==========================================
+ Hits 295014 295258 +244
- Misses 9805 9827 +22
Partials 2378 2378 |
mavasani
reviewed
Jul 8, 2022
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2022
mavasani
approved these changes
Jul 8, 2022
|
Moving to draft until dotnet/roslyn#7578 resolved and the |
|
@buyaa-n dotnet/roslyn#7578 has been implemented, so we should soon have a public API |
|
Closing out this old draft PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5971
CA1416 is disabled for generated code, but we need to enable them for razor/shtml pages
As proposed in dotnet/roslyn#39758: Roslyn already recognizes
<auto-generated />in a comment on the beginning of source files. We could extend this with an optional type attribute:// <auto-generated type="Razor" />We also want to support *.cshtml files, that means the type name might change
- [ ] Add VB testVB not supportedtype="Razor"attribute to the<auto-generated/>commentCreating the PR as a draft until all checks fixedThe PR now ready for review