Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate PackageReference #6032

Merged
merged 4 commits into from Jun 25, 2022
Merged

Remove duplicate PackageReference #6032

merged 4 commits into from Jun 25, 2022

Conversation

Youssef1313
Copy link
Member

The other reference comes from

roslyn-analyzers/src/Utilities/Compiler/Analyzer.Utilities.projitems

Lines 145 to 147 in 0e7f40d

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Common" Version="$(MicrosoftCodeAnalysisVersion)" />
</ItemGroup>

@Youssef1313 Youssef1313 requested a review from a team as a code owner June 24, 2022 14:01
@Youssef1313 Youssef1313 mentioned this pull request Jun 24, 2022
Merged
mavasani
mavasani approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mavasani mavasani enabled auto-merge June 24, 2022 14:39
@Youssef1313
Copy link
Member Author

@mavasani @sharwell I'm not sure about the remaining failure here.

@Youssef1313
Copy link
Member Author

dotnet/sdk#24747 (comment) has some details. FYI @jmarolf

auto-merge was automatically disabled June 24, 2022 20:50

Head branch was pushed to by a user without write access

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #6032 (bcee4e7) into main (0e7f40d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6032   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files        1338     1338           
  Lines      307164   307164           
  Branches     9787     9787           
=======================================
+ Hits       294978   294979    +1     
+ Misses       9809     9808    -1     
  Partials     2377     2377

@Youssef1313
Copy link
Member Author

@mavasani @sharwell @jmarolf This is green now.

@mavasani mavasani merged commit 7c88690 into dotnet:main Jun 25, 2022
@github-actions github-actions bot added this to the vNext milestone Jun 25, 2022
@Youssef1313 Youssef1313 deleted the patch-16 branch June 25, 2022 05:41
@mavasani mavasani mentioned this pull request Jun 28, 2022
Merged
JoeRobich added a commit to mavasani/roslyn-analyzers that referenced this pull request Jun 28, 2022
@JoeRobich
Remove duplicate package reference (port of dotnet#6032)
3f9bd28
@jmarolf jmarolf modified the milestones: vNext, .NET 7.x Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
.NET vNext
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Youssef1313 @sharwell @mavasani @jmarolf