Fixes CA1854 replacing unrelated dictionaries with matching signatures #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Analyzer to first find ContainsKey and than find all usages with the same unchanged key and dictionary reference in the guarded path. Fixes: dotnet#6256
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6387 +/- ##
==========================================
- Coverage 96.41% 96.40% -0.02%
==========================================
Files 1374 1374
Lines 320382 320858 +476
Branches 10314 10387 +73
==========================================
+ Hits 308906 309320 +414
- Misses 9008 9057 +49
- Partials 2468 2481 +13 |
Youssef1313
reviewed
Dec 27, 2022
...ers/VisualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferDictionaryTryGetValueFixer.vb
Outdated
Show resolved
Hide resolved
|
is there still something that needs to be changed? |
This was referenced Jan 22, 2023
Merged
|
@Youssef1313 or @mavasani could one of you do another review. Thanks |
|
@buyaa-n Can you please review? Thanks! |
|
@Miizukii for resolving merge conflicts |
buyaa-n
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Analyzer to first find ContainsKey() and than find all usages with the same unchanged key and dictionary reference in the guarded path.
Fixes: #6256, #6390, #6280