Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add review comment to sb files #6666

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

oleksandr-didyk
Copy link
Contributor

Contributes to dotnet/source-build#3435

Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #6666 (cfa623a) into main (f4cc17e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6666      +/-   ##
==========================================
- Coverage   96.36%   96.36%   -0.01%     
==========================================
  Files        1390     1390              
  Lines      324039   324039              
  Branches    10613    10613              
==========================================
- Hits       312274   312271       -3     
- Misses       9224     9226       +2     
- Partials     2541     2542       +1     

@oleksandr-didyk
Copy link
Contributor Author

@dotnet/roslyn-analysis soft ping - would be great if someone could take a look at this small PR. Thank you!

@oleksandr-didyk
Copy link
Contributor Author

Reached out to @sharwell in DMs - agreed to add a CODEOWNERS entry for affected source-build files and write permissions for the @dotnet/source-build-internal team alias to make the entry valid

@sharwell sharwell merged commit 953ae27 into dotnet:main Jun 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants