Prevent surfacing OperationCanceledException as diagnostic #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Jun 21, 2023
...ysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/AbstractResxGenerator.cs
Outdated
Show resolved
Hide resolved
…nalysis.ResxSourceGenerator/AbstractResxGenerator.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6702 +/- ##
==========================================
- Coverage 96.38% 96.37% -0.01%
==========================================
Files 1386 1386
Lines 323483 323487 +4
Branches 10567 10567
==========================================
- Hits 311775 311772 -3
- Misses 9181 9187 +6
- Partials 2527 2528 +1 |
sharwell
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't seen the exception being surfaced as a diagnostic, but from reading the code, it seems possible.