Implement RS1038 (Strict compiler reference analysis) #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
strict-references
branch
from
1b4d220
to
1a0c5ff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6705 +/- ##
==========================================
- Coverage 96.39% 96.37% -0.02%
==========================================
Files 1379 1390 +11
Lines 322290 324027 +1737
Branches 10461 10609 +148
==========================================
+ Hits 310659 312283 +1624
- Misses 9137 9205 +68
- Partials 2494 2539 +45 |
sharwell
force-pushed
the
strict-references
branch
2 times, most recently
from
f448526
to
00c3590
Compare
sharwell
force-pushed
the
strict-references
branch
from
00c3590
to
21a5c52
Compare
mavasani
approved these changes
Jun 22, 2023
sharwell
force-pushed
the
strict-references
branch
2 times, most recently
from
1e7e8d9
to
75097ba
Compare
roslyn_correctness.assembly_reference_validation = relaxed
sharwell
force-pushed
the
strict-references
branch
from
75097ba
to
cc316f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement rule for strict reference analysis
Update documentation for compiler references
Add "strict" option, where RS1038 is only enabled in strict mode, and RS1022 is only enabled in relaxed mode
This was initially implemented by setting RS1022 to disabled-by-default, and RS1038 to enabled-by-default. Manually enabling RS1022 will restore its behavior. However, users are unlikely to know to enable RS1022 manually when RS1038 is disabled, so these should be controlled by a dedicated option.
Relaxed validation (RS1022) may be manually enabled by adding the following to .globalconfig:
roslyn_correctness.assembly_reference_validation = relaxedFixes #6676