Remove error when targeting net8.0-browser1.0 TFM #6707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
==========================================
- Coverage 96.38% 96.37% -0.01%
==========================================
Files 1386 1386
Lines 323483 323497 +14
Branches 10567 10568 +1
==========================================
+ Hits 311775 311782 +7
- Misses 9181 9184 +3
- Partials 2527 2531 +4 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding support for the
net8.0-browserTFM (see dotnet/runtime#85333) and noticed the platform analyzer complains because we're using version 1.0 but there is noIsBrowserVersionAtLeast()method.As far as I know we don't plan to add one (at least right now) which makes Browser a special case.
/cc @lewing @steveisok