Fix a few bugs in CA1859. #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Jun 23, 2023
Comment on lines
+49
to
+73
| I obj = new Derived(); | ||
| obj.M(); |
There was a problem hiding this comment.
💭 It seems like this would still work:
Derived obj = new Derived();
((I)obj).M();
Not sure it's better though.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6709 +/- ##
==========================================
- Coverage 96.38% 96.36% -0.02%
==========================================
Files 1386 1395 +9
Lines 323491 325074 +1583
Branches 10567 10676 +109
==========================================
+ Hits 311782 313260 +1478
- Misses 9181 9247 +66
- Partials 2528 2567 +39 |
mavasani
reviewed
Jun 29, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/UseConcreteTypeAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jun 29, 2023
src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Performance/UseConcreteTypeTests.cs
Show resolved
Hide resolved
mavasani
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6659
Fixed #6565
Fixes #6687
Fixes #6704