Fix DiagnosticAnalyzerFieldsAnalyzer for delegate fields #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6724 +/- ##
==========================================
- Coverage 96.32% 96.32% -0.01%
==========================================
Files 1389 1389
Lines 325167 325396 +229
Branches 10724 10727 +3
==========================================
+ Hits 313232 313450 +218
- Misses 9225 9234 +9
- Partials 2710 2712 +2 |
|
@CollinAlpert Is there a github issue tracking this bug or was this identified by you through dogfooding? |
mavasani
reviewed
Jul 3, 2023
| @@ -8,6 +9,25 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Analyzers.MetaAnalyzers | |||
| <DiagnosticAnalyzer(LanguageNames.VisualBasic)> | |||
| Public Class BasicDiagnosticAnalyzerFieldsAnalyzer | |||
| Inherits DiagnosticAnalyzerFieldsAnalyzer(Of ClassBlockSyntax, StructureBlockSyntax, FieldDeclarationSyntax, TypeSyntax, SimpleAsClauseSyntax) | |||
|
|
|||
| Protected Overrides Function IsContainedInFuncOrAction(typeSyntax As TypeSyntax, model As SemanticModel, funcs As ImmutableArray(Of INamedTypeSymbol), actions As ImmutableArray(Of INamedTypeSymbol)) As Boolean | |||
There was a problem hiding this comment.
Can we add VB tests for this scenario?
There was a problem hiding this comment.
Done. I simplified the check to use DelegateInvokeMethod.
mavasani
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the warning for storing per-compilation data inside an analyzer field, when that field is a delegate type.