Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1853: Address issues found in PR review #6767 #6791

Merged
merged 4 commits into from
Sep 20, 2023
Merged

CA1853: Address issues found in PR review #6767 #6791

merged 4 commits into from
Sep 20, 2023

Commits on Aug 19, 2023

  1. Rename do not guard set analyzer and fixer 

    This is done in a separate commit, so that the actual changes can be
seen in the next commit. This is because git would not recognize the
rename if the changes were added as is.

Note that this commit by itself is broken.
    @mpidash
    mpidash committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    c148b14 View commit details
    Browse the repository at this point in the history

  2. Combine analyzers for guarded calls 

    This combines the analyzers CA1853 and CA1868 to avoid code duplication,
make CA1853 support the same range of cases as CA1868 and fix dotnet#6781.
    @mpidash
    mpidash committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b50e28d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Apply suggestions from code review

    @buyaa-n
    buyaa-n committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f29ad54 View commit details
    Browse the repository at this point in the history

  2. Update parameter name

    @buyaa-n
    buyaa-n committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3496725 View commit details
    Browse the repository at this point in the history