Don't emit CA1508 in Debug.Assert

[CollinAlpert]

Fixes #6983

[codecov]

Codecov Report

Merging #7014 (de0cfa1) into main (b40db00) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #7014   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files        1412     1412           
  Lines      336397   336421   +24     
  Branches    11114    11131   +17     
=======================================
+ Hits       324382   324410   +28     
+ Misses       9212     9207    -5     
- Partials     2803     2804    +1     

[mavasani]

Will this work if Debug.Assert expressions is more complex, say Debug.Assert(MyConstant == 16 && MyConstant2 == 17); where MyConstant2 is another constant with value 17?

I think a better approach would be to revert the changes to ShouldAnalyze and instead add a ShouldReport(IOperation op) helper that gets called just prior to context.ReportDiagnostic calls in this analyzer, and that one can do a walk up the operation tree and check if any of the ancestor IInvocationOperation is a call to a debug assert method.

[CollinAlpert]

I thought about that approach as well, but was hesitant about implementing a plain walk-up, since we could have something like this, which IMO should be flagged: Debug.Assert(MethodCall(MyConstant == 16));

[mavasani]

Sounds reasonable. We can revisit this in future if needed. Thanks for the fix.