-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report CA2257 on nested types #7157
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7157 +/- ##
==========================================
+ Coverage 96.33% 96.44% +0.11%
==========================================
Files 1389 1415 +26
Lines 325649 338212 +12563
Branches 10735 11191 +456
==========================================
+ Hits 313699 326180 +12481
+ Misses 9236 9212 -24
- Partials 2714 2820 +106 |
Since this is a servicing change, this would need to go through Tactics. Can you please fill out the typical template (like the one we use in runtime) and send an email to Tactics requesting approval? |
This is not meant to be a servicing change. Which branch do I need to target for this to be non-servicing? Is it main or a different release/8.0.yxx branch? |
It should go to main. |
I think it might be easier to resubmit the PR rather than retargeting the PR to the main branch. Otherwise a bunch of unrelated commits might end up getting included in the PR. I suspect that's what @sharwell saw when attempting it and then reverting it in the two moves above. |
4949055
to
781d2ac
Compare
I rebased the PR onto main and then changed the branch, so it only has my commit. @sharwell this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #7106