Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust message for banned symbol CultureInfo.CurrentCulture #7167

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Adjust message for banned symbol CultureInfo.CurrentCulture #7167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b1bf5e
Update AnalyzerBannedSymbols.txt
RikkiGibson Jan 31, 2024
59ee232
Apply suggestions from code review
RikkiGibson Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.CodeAnalysis.Analyzers/Core/AnalyzerBannedSymbols.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ T:System.Console; Analyzers should not be reading / writing to the console
T:System.Diagnostics.Process; Analyzers should not inspect or create processes
T:System.Diagnostics.ProcessStartInfo; Analyzers should not inspect or create processes
T:System.Environment; Analyzers should not read their settings directly from environment variables
P:System.Globalization.CultureInfo.CurrentCulture; Analyzers should use the locale given by the compiler command line arguments, not the CurrentCulture
P:System.Globalization.CultureInfo.CurrentUICulture; Analyzers should use the locale given by the compiler command line arguments, not the CurrentUICulture
P:System.Globalization.CultureInfo.CurrentCulture; Analyzers should use LocalizableResourceString for culture-dependent messages
P:System.Globalization.CultureInfo.CurrentUICulture; Analyzers should use LocalizableResourceString for culture-dependent messages
RikkiGibson marked this conversation as resolved.
Show resolved Hide resolved
T:System.IO.File; Do not do file IO in analyzers
T:System.IO.Directory; Do not do file IO in analyzers
M:System.IO.Path.GetTempPath; Do not do file IO in analyzers
Expand Down