Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar for CA2262's description #7169

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix grammar for CA2262's description #7169

merged 2 commits into from
Feb 1, 2024

Conversation

gewarren
Copy link
Contributor

Grammar wasn't correct.

@gewarren gewarren requested a review from a team as a code owner January 31, 2024 16:58
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying resx files needs a full build in your local machine. It will generate a bunch of additional files for translations that you need to include in your PR. Can you please do that as well?

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0781c1) 96.44% compared to head (6339ec2) 96.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7169   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files        1415     1415           
  Lines      338191   338191           
  Branches    11191    11191           
=======================================
+ Hits       326154   326157    +3     
+ Misses       9216     9214    -2     
+ Partials     2821     2820    -1     

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buyaa-n buyaa-n merged commit 4485df6 into dotnet:main Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants