Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about ignored method result for IQueryable #7182

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

CollinAlpert
Copy link
Contributor

@CollinAlpert CollinAlpert commented Feb 7, 2024

Fixes #7030

@CollinAlpert CollinAlpert requested a review from a team as a code owner February 7, 2024 19:32
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0311fb) 96.44% compared to head (9590e33) 96.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7182      +/-   ##
==========================================
- Coverage   96.44%   96.44%   -0.01%     
==========================================
  Files        1415     1415              
  Lines      338191   338198       +7     
  Branches    11191    11191              
==========================================
+ Hits       326166   326170       +4     
- Misses       9205     9208       +3     
  Partials     2820     2820              

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @CollinAlpert

@buyaa-n buyaa-n merged commit 4195460 into dotnet:main Feb 22, 2024
14 checks passed
@CollinAlpert CollinAlpert deleted the issue-7030 branch February 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1806 - False-negative for IQueryable Take()
2 participants