Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report RS1008 for ISymbol and IOperation fields #7197

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Feb 17, 2024

Fixes #7196.

@mpidash mpidash requested a review from a team as a code owner February 17, 2024 11:19
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90721b0) 96.45% compared to head (d71ebc8) 96.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7197      +/-   ##
==========================================
- Coverage   96.45%   96.45%   -0.01%     
==========================================
  Files        1422     1422              
  Lines      340539   340551      +12     
  Branches    11230    11231       +1     
==========================================
+ Hits       328470   328477       +7     
- Misses       9231     9236       +5     
  Partials     2838     2838              

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @mavasani another look.

@buyaa-n buyaa-n requested a review from mavasani March 1, 2024 17:06
@mavasani mavasani merged commit 628d239 into dotnet:main Mar 5, 2024
11 checks passed
@mpidash mpidash deleted the issue-7196 branch March 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RS1008 not reported on ISymbol fields of diagnostic analyzer
3 participants