Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for RefKind.RefReadOnlyParameter in RS0042 (Do not copy value) #7254

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Improve support for RefKind.RefReadOnlyParameter in RS0042 (Do not copy value) #7254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Roslyn.Diagnostics.Analyzers/Core/AbstractDoNotCopyValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,9 +1350,8 @@ private static bool CanAssign(RefKind sourceRefKind, RefKind targetRefKind)
return (sourceRefKind, targetRefKind) switch
{
(RefKind.None, _) => true,
(RefKind.Ref, RefKind.Ref) => true,
(RefKind.Ref, RefKind.RefReadOnly or RefKindEx.RefReadOnlyParameter) => true,
(RefKind.RefReadOnly, RefKind.RefReadOnly or RefKindEx.RefReadOnlyParameter) => true,
(RefKind.Ref, RefKind.Ref or RefKind.RefReadOnly or RefKindEx.RefReadOnlyParameter) => true,
(RefKind.RefReadOnly or RefKindEx.RefReadOnlyParameter, RefKind.RefReadOnly or RefKindEx.RefReadOnlyParameter) => true,
_ => false,
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/Roslyn.Diagnostics.Analyzers/UnitTests/DoNotCopyValueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ internal sealed class NonCopyableAttribute : System.Attribute {{ }}
[Theory]
[CombinatorialData]
public async Task AllowUnsafeAsRefParameterReference2Async(
[CombinatorialValues("ref", "in")] string parameterModifiers,
[CombinatorialValues("ref", "in", "ref readonly")] string parameterModifiers,
[CombinatorialValues("in", "scoped in", "ref readonly", "scoped ref readonly")] string asRefParameterModifiers)
{
var source = $@"
Expand Down