Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the parsing ahead for deconstruction-declarations to avoid allocations #12399

Closed
jcouv opened this issue Jul 8, 2016 · 1 comment
Closed
Assignees
Labels
Area-Compilers Feature Request New Language Feature - Tuples Tuples Resolution-Not Applicable The issue is not relevant to code in this repo and is not an external issue. Tenet-Performance Regression in measured performance of the product from goals.
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented Jul 8, 2016

        /// <summary>
        /// Check ahead for a deconstruction declaration. This requires at least one good-looking variable and the presence of an equals sign.
        /// Doesn't move the cursor.
        /// PROTOTYPE(tuples) Can this be done without allocations?
        /// </summary>
        private bool IsPossibleDeconstructionDeclaration()

in LanguageParser.cs

@jcouv jcouv self-assigned this Jul 8, 2016
@gafter gafter added Feature Request Tenet-Performance Regression in measured performance of the product from goals. labels Jul 17, 2016
@gafter gafter added this to the 2.0 (RTM) milestone Jul 17, 2016
@jcouv
Copy link
Member Author

jcouv commented Dec 6, 2016

The parsing ahead will be reduced after the new parsing for declaration expressions #15548

@jcouv jcouv closed this as completed Dec 6, 2016
@jcouv jcouv added the Resolution-Not Applicable The issue is not relevant to code in this repo and is not an external issue. label Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature Request New Language Feature - Tuples Tuples Resolution-Not Applicable The issue is not relevant to code in this repo and is not an external issue. Tenet-Performance Regression in measured performance of the product from goals.
Projects
None yet
Development

No branches or pull requests

2 participants