Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing ahead for 'for' and 'foreach' ambiguities should recognize deconstructions #12402

Open
jcouv opened this issue Jul 8, 2016 · 3 comments

Comments

@jcouv
Copy link
Member

jcouv commented Jul 8, 2016

        [Fact(Skip = "PROTOTYPE(tuples)")]
        public void ConfusedForWithDeconstruction()
        {
            var text = "for ((int x, var (y, z)) in foo) { }";
            var statement = SyntaxFactory.ParseStatement(text, offset: 0, options: TestOptions.Regular.WithTuplesFeature());

            // This expectation is wrong. We should expect a foreach statement (because the 'in' keyword is there)
            Assert.True(statement.Kind() == SyntaxKind.ForStatement);
        }
@jcouv
Copy link
Member Author

jcouv commented Aug 10, 2016

FYI for @gafter

@jcouv jcouv modified the milestones: 2.0 (RTM), 2.0 (RC) Oct 3, 2016
@jcouv jcouv modified the milestones: 2.1, 2.0 (RTM) Jan 11, 2017
@gafter gafter added this to Backlog in Compiler: Tuples Feb 20, 2017
@jcouv jcouv added this to the Unknown milestone Apr 9, 2017
@jcouv
Copy link
Member Author

jcouv commented May 12, 2017

I think it's unlikely we'll end up doing this. Closing.

@jcouv jcouv closed this as completed May 12, 2017
@jcouv jcouv moved this from Backlog to Closed in Compiler: Tuples May 28, 2017
@gafter
Copy link
Member

gafter commented Nov 19, 2018

There remains a skipped test with this issue ID.

@gafter gafter reopened this Nov 19, 2018
@gafter gafter modified the milestones: Unknown, 16.0.P2 Nov 19, 2018
@jcouv jcouv modified the milestones: 16.0.P2, 16.0 Dec 21, 2018
@jcouv jcouv modified the milestones: 16.0, 16.1, 16.2 Apr 18, 2019
@jcouv jcouv modified the milestones: 16.2, Backlog Jun 19, 2019
@jcouv jcouv removed their assignment Jun 19, 2019
@jcouv jcouv modified the milestones: Backlog, 16.3 Jun 19, 2019
@jcouv jcouv modified the milestones: 16.3, Backlog Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants