Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeFixes that alter AdditionalFiles do not save the changes #13561

Closed
dpoeschl opened this issue Sep 2, 2016 · 3 comments
Closed

CodeFixes that alter AdditionalFiles do not save the changes #13561

dpoeschl opened this issue Sep 2, 2016 · 3 comments
Assignees
Milestone

Comments

@dpoeschl
Copy link
Contributor

dpoeschl commented Sep 2, 2016

Version Used: VS 15 Preview 4

Steps to Reproduce:

  1. Enlist in Roslyn, under source control
  2. Change something from internal to public
  3. Use the Public API analyzer/fixer to add the newly public thing to the PublicAPI.Unshipped.txt file

Expected Behavior: PublicAPI.Unshipped.txt should be saved, and show as changed under source control

Actual Behavior: PublicAPI.Unshipped.txt is not saved until you Save All in VS.

@dpoeschl
Copy link
Contributor Author

dpoeschl commented Sep 2, 2016

Some potential psychic debugging from @Pilchie elsewhere: "Sounds like we're missing a dispose on an invisible editor somewhere"

@dpoeschl
Copy link
Contributor Author

dpoeschl commented Sep 2, 2016

Also /cc: @tmeschter

@Pilchie Pilchie added the Bug label Sep 6, 2016
@Pilchie Pilchie added this to the 2.0 (RC) milestone Sep 6, 2016
@rchande rchande modified the milestones: 2.1, 2.0 (RC) Sep 19, 2016
@Pilchie Pilchie modified the milestones: 15.1, 15.3 Mar 29, 2017
@jasonmalinowski
Copy link
Member

Oh, hey, turns out it's dotnet/project-system#2160 that I filed after investigating. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants