Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstruction: Don't prematurely resolve lazy diagnostics #13828

Closed
jcouv opened this issue Sep 15, 2016 · 1 comment
Closed

Deconstruction: Don't prematurely resolve lazy diagnostics #13828

jcouv opened this issue Sep 15, 2016 · 1 comment
Assignees
Labels
Area-Compilers New Language Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented Sep 15, 2016

See comment

I missed this during the previous review. It might be inappropriate to use HasAnyErrors here. There are at least two reasons for that:

It resolves lazy diagnostics, which could create circularity problems in certain contexts.
Lazy errors shouldn't really fail the binding. An example would be an obsolete Deconstruct method. Yes, it is an error to use it, but that shouldn't prevent us from recording the actual binding information and continuing to the next level. I.e. we shouldn't complain that we couldn't find a suitable method.
Consider using HasAnyResolvedErrors instead and adding a test with an obsolete Deconstruct method.

Split this issue from the umbrella for deconstruction work items #11299

@jcouv jcouv added this to the 2.0 (RC) milestone Sep 15, 2016
@jcouv jcouv self-assigned this Sep 15, 2016
@jcouv jcouv added 4 - In Review A fix for the issue is submitted for review. Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Sep 18, 2016
@jcouv
Copy link
Member Author

jcouv commented Sep 20, 2016

Fixed by #13892

@jcouv jcouv closed this as completed Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Language Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

1 participant