Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddVariableExpressions lacks coverage #15095

Open
jcouv opened this issue Nov 8, 2016 · 0 comments
Open

AddVariableExpressions lacks coverage #15095

jcouv opened this issue Nov 8, 2016 · 0 comments
Labels
Area-Compilers Test Test failures in roslyn-CI
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented Nov 8, 2016

In CSharpProximityExpressionsService.RelevantExpressionsCollector.cs

The code below doesn't seem covered by tests (it used to have an infinite recursion bug).

            private void AddVariableExpressions(
                ExpressionSyntax component,
                IList<string> expressions)
            {
                if (!_includeDeclarations) return;

                switch (component.Kind())
                {
                    case SyntaxKind.TupleExpression:
                        {
                            var t = (TupleExpressionSyntax)component;
                            foreach (ArgumentSyntax a in t.Arguments) AddVariableExpressions(a.Expression, expressions);
                            break;
                        }
                    case SyntaxKind.DeclarationExpression:
                        {
                            var t = (DeclarationExpressionSyntax)component;
                            AddVariableExpressions(t.Designation, expressions);
                            break;
                        }
                }
            }
@jcouv jcouv added this to the 2.0 (RC.3) milestone Nov 8, 2016
@jcouv jcouv self-assigned this Nov 8, 2016
@jcouv jcouv modified the milestones: 2.0 (RTM), 2.0 (RC.3) Nov 29, 2016
@jcouv jcouv modified the milestones: 2.1, 2.0 (RTM) Jan 8, 2017
@gafter gafter added this to Backlog in Compiler: Tuples Feb 20, 2017
@jcouv jcouv added the Test Test failures in roslyn-CI label Mar 2, 2017
@jcouv jcouv modified the milestones: 2.1, 2.2 Mar 3, 2017
@jcouv jcouv modified the milestones: 15.2, 15.3 Mar 11, 2017
@jcouv jcouv modified the milestones: 15.later, 15.3 Apr 5, 2017
@jcouv jcouv removed their assignment Aug 28, 2017
@jcouv jcouv modified the milestones: Unknown, 15.later Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
No open projects
Development

No branches or pull requests

1 participant