Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CoreCompile consume the ReferenceDependencyPaths item? #19053

Open
rainersigwald opened this issue Apr 27, 2017 · 1 comment
Open

Should CoreCompile consume the ReferenceDependencyPaths item? #19053

rainersigwald opened this issue Apr 27, 2017 · 1 comment

Comments

@rainersigwald
Copy link
Member

More context is available at dotnet/msbuild#1520 (comment).

MSBuild's standard ResolveAssemblyReferences target emits a ReferencePath item containing references, and additionally emits a ReferenceDependencyPaths item containing the facade assemblies needed for the current framework target. Other compile-like steps use ReferenceDependencyPaths but CoreCompile does not.

Instead, the NETFramework.targets includes an ImplicitlyExpandDesignTimeFacades target that includes all assemblies from the facades directory into ReferencePath as a post-processing step.

Is this intentional, or an accident of history? It seems like we could eliminate ImplicitlyExpandDesignTimeFacades if CoreCompile consumed this additional item as references.

/cc @ericstj @cdmihai

@jaredpar jaredpar added this to the 16.0 milestone Jul 7, 2017
@ericstj
Copy link
Member

ericstj commented Sep 29, 2017

New piece of data I happened upon today.

ReferenceDependencyPaths is returned as part of BuiltProjectOutputGroupDependency, which is used by both Web Projects and ClickOnce packaging to mean "files that the app wants to copy along side it". This seems inconsistent with usage, since ReferenceCopyLocalPaths is actually what gets copied next to the app.

Any chance you guys can dig up an initial spec on this stuff?

@jinujoseph jinujoseph modified the milestones: 16.0, 16.3 Jun 9, 2019
@jcouv jcouv modified the milestones: 16.3, Compiler.Next Jul 8, 2019
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants