Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for lifted variables in async/iterator code #23929

Open
gafter opened this issue Dec 26, 2017 · 1 comment
Open

Add tests for lifted variables in async/iterator code #23929

gafter opened this issue Dec 26, 2017 · 1 comment
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Test Test failures in roslyn-CI
Projects
Compiler: Engineering Investments
Milestone
Backlog

Comments

@gafter
Copy link
Member

gafter commented Dec 26, 2017

We do not have many tests that verify the set of variables lifted in async or iterator code. It would be good to add a bit of testing infrastructure to make that easy, and add tests. Also, this could be added to the checklist for new features.
@gafter gafter added Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Test Test failures in roslyn-CI labels Dec 26, 2017
@gafter gafter mentioned this issue Dec 26, 2017
Merged
@gafter
Copy link
Member Author

gafter commented Dec 26, 2017

Functional tests do not work for this because extra lifted variables are not observable in the runtime behavior.

@gafter gafter added this to the Compiler.Next milestone Aug 4, 2019
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Test Test failures in roslyn-CI
Projects
Compiler: Engineering Investments
  
Triage
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jaredpar @gafter