Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branchless codegen for lifted nullable operators | and & #26009

Open
gafter opened this issue Apr 6, 2018 · 2 comments
Open

Branchless codegen for lifted nullable operators | and & #26009

gafter opened this issue Apr 6, 2018 · 2 comments
Labels
Area-Compilers Code Gen Quality Room for improvement in the quality of the compiler's generated code help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@gafter
Copy link
Member

gafter commented Apr 6, 2018

It would be nice to have improved code gen for & and | analogous to the changes in #25992.

For VB too.
@gafter gafter added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-Compilers labels Apr 6, 2018
@gafter gafter added this to the Unknown milestone Apr 6, 2018
@gafter
Copy link
Member Author

gafter commented Apr 6, 2018

/cc @alrz

@YairHalberstadt
Copy link
Contributor

So

a | b
// is currently
a.HasValue & b.HasValue ? a.GetValueOrDefault() & b.GetValueOrDefault() : null

I can't see what this is meant to be converted into?

Unless you were specifically talking about booleans?

@gafter gafter added the Code Gen Quality Room for improvement in the quality of the compiler's generated code label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Code Gen Quality Room for improvement in the quality of the compiler's generated code help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@gafter @YairHalberstadt