Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many skipped tests have skip reasons referring to obsolete bug tracking systems #31270

Open
gafter opened this issue Nov 19, 2018 · 0 comments
Open
Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone

Comments

@gafter
Copy link
Member

gafter commented Nov 19, 2018

Many compiler tests are skipped with skip reasons referring to just a number, which is apparently a reference to some obsolete bug tracking system. We should have an issue in github for every skipped test.

Here is a small sampling:

R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\Source\PropertyTests.cs(1177):        [Fact(Skip = "527664")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\Source\PropertyTests.cs(1200):        [Fact(Skip = "527657")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\Source\PropertyTests.cs(1239):        [Fact(Skip = "527660")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\Source\PropertyTests.cs(1300):        [Fact(Skip = "527656")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\ExtensionMethodTests.cs(754):        [Fact(Skip = "528425")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\ExtensionMethodTests.cs(1211):        [Fact(Skip = "528425")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\ExtensionMethodTests.cs(2940):        [Fact(Skip = "529596")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\IndexedPropertyTests.cs(2523):        [Fact(Skip = "530571")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\IndexerTests.cs(1430):        [Fact(Skip = "528830")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\InterfaceImplementationTests.cs(1423):        [Fact(Skip = "528858")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\InterfaceImplementationTests.cs(1442):        [Fact(Skip = "528901")]
  R:\Roslyn\src\Compilers\CSharp\Test\Symbol\Symbols\InterfaceImplementationTests.cs(1806):        [Fact(Skip = "528913")]
@gafter gafter added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label Dec 5, 2018
@gafter gafter added this to the Backlog milestone Dec 5, 2018
@gafter gafter added this to Sooner rather than Later in Compiler: Engineering Investments May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
Compiler: Engineering Investments
  
Sooner rather than Later (sorted)
Development

No branches or pull requests

1 participant