Assert in completion in razor file

[heejaechang]

repro step is just create razor project and add empty cstml file at the root.

remove everything in the cstml and type this at the top

@await Html.PartialAsync

...

...

---

Assertion Failed: Abort=Quit, Retry=Debug, Ignore=Continue

Unexpected value 'ExtensionMethod' of type 'System.String'

at Roslyn.Utilities.ExceptionUtilities.UnexpectedValue(Object o)

at Microsoft.CodeAnalysis.Classification.ClassificationTags.GetClassificationTypeName(String textTag)

at Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Presentation.ToolTipProvider.CancellableContentControl.GetVisibleDisplayString(TaggedText part, Boolean includeLeftToRightMarker)

at Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Presentation.ToolTipProvider.CancellableContentControl.GetRun(TaggedText part, IClassificationFormatMap formatMap, ClassificationTypeMap typeMap)

at Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Presentation.ToolTipProvider.CancellableContentControl.GetTextBlock(ImmutableArray`1 parts)

at Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.Completion.Presentation.ToolTipProvider.CancellableContentControl.ProcessDescription(Task`1 obj)

at System.Threading.Tasks.ContinuationTaskFromResultTask`1.InnerInvoke()

at System.Threading.Tasks.Task.Execute()

at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)

at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)

at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)

at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)

at System.Threading.Tasks.SynchronizationContextTaskScheduler.PostCallback(Object obj)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

at System.Windows.Threading.DispatcherOperation.InvokeImpl()

at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)

at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)

at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)

at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)

at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)

at System.Windows.Threading.DispatcherOperation.Invoke()

at System.Windows.Threading.Dispatcher.ProcessQueue()

at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)

at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

---

Abort Retry Ignore

[heejaechang]

happening in master.

tagging @ivanbasov since it is completion and tagging @JoeRobich since it looks like something with classification in completion.

[JoeRobich]

Interesting. I know Ivan updated other methods like this to redirect to the TaggedText extension method. I guess we just duplicated this numerous times.

[ivanbasov]

GetRun and GetVisibleDisplayString point to methods deleted in preview 2 by #32307

[JoeRobich]

@ivanbasov Those changes went into -vs-deps. Is there any reason not to take those same changes into the non-vs-deps branches?

[ivanbasov]

@JoeRobich, we ship from -vs-deps. That is why changes were sent to -vs-deps.

There is no reason not to merge #32307 into non -vs-deps, i.e. we can merge it. Please let me know if you need my help doing this.