Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests should correctly wait for workspace operations #33670

Open
sharwell opened this issue Feb 25, 2019 · 0 comments
Open

Integration tests should correctly wait for workspace operations #33670

sharwell opened this issue Feb 25, 2019 · 0 comments
Labels
Area-IDE Bug IDE-Project Project system and MSBuild interactions Integration-Test Test failures in roslyn-integration-CI
Milestone

Comments

@sharwell
Copy link
Member

sharwell commented Feb 25, 2019

Currently, waits for FeatureAttribute.Workspace only wait for operations tracked by Roslyn. These waits should first wait for asynchronous operations to be processed by the underlying project system(s), and then wait for remaining operations tracked by Roslyn.

This code is not correct, but cannot be made correct today. The project systems do (or will do soon in the case of csproj) design time builds asynchronously, and there is no strict guarantee that states that the design time build must be complete after the rename has been applied from the perspective of DTE. There might be code today that happens to force a synchronization but that's not in the contract. What is required prior to the WaitForAsyncOperation is a wait on the project system that it's pushed the work to the workspace, but the API to do didn't get completed in time for 16.0.

Originally posted by @jasonmalinowski in #33662 (comment)

@sharwell sharwell added Bug Area-IDE Integration-Test Test failures in roslyn-integration-CI IDE-Project Project system and MSBuild interactions labels Feb 25, 2019
@sharwell sharwell added this to the 16.1 milestone Feb 25, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug IDE-Project Project system and MSBuild interactions Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Development

No branches or pull requests

2 participants