Array of pointer not diagnosed

[gafter]

As observed by #34693 (comment) the following program fails to report the incorrect use of a pointer type after #34739

public class A {
    public class B {}
}

public class C<T> : A {
    public C<string*[]>.B field; // error: pointer to managed type
}

here is another case that isn't properly diagnosed:

public class A
{
    public class Inner {}
}

public class B<T> : A where T : unmanaged
{
}

public class C
{
    B<string>.Inner field;
}

[RikkiGibson]

I wasn't precise enough in my comment there. As far as I can tell, the first case with string* is diagnosed because the "unmanaged constraint" on pointers is checked at the time C<string*[]> is bound--and we have a test for this. The second case however isn't caught because we check the type parameter's constraints after field types are bound.

As @cston pointed out (I think only offline?) there is a similar bug with method return types in 2.9.0 and today:

public class A
{
    public class Inner {}
}

public class B<T> : A where T : unmanaged
{
}

public class C
{
    B<string>.Inner M() => throw null;
}

This bug is likely to be present in every case where constraints are checked after binding instead of during binding.

[gafter]

In that case, moving to Backlog.